Load grids with xarray and then create uxarray grid object by rajeeja · Pull Request #162 · UXARRAY/uxarray

rajeeja · 2022-10-20T20:03:55Z

#151 and Discussion: #154

…taset.py and modify all tests #151 and Discussion: #154

philipc2

Great work @rajeeja! I've left a couple comments about some slightly inconsistencies with casting face nodes to integers. Other than that, the implementation is looking great!

philipc2 · 2022-10-24T18:23:54Z

Small suggestion for the Grid constructor, but also applies to most of our other functions: Do we want to implement type hints?

Our current constructor for grid is:
__init__(self, dataset, **kwargs):

A simple change to emphasize that we are using xr.Dataset would be as follows
__init__(self, dataset : xr.Dataset, **kwargs):

rajeeja · 2022-10-24T18:26:42Z

Great work @rajeeja! I've left a couple comments about some slightly inconsistencies with casting face nodes to integers. Other than that, the implementation is looking great!

Thanks! I'll fix these later today.

erogluorhan

Thank very much for doing this! Please address a few things as follows:

Reflect the removal of the dataset functionality in the documentation (e.g. user API, draft UXarray API, etc.)
Inline comments

…t_integrate, put those tests in test_grid - one test per .py file in uxarray folder

…ray into rajeeja/remove_open_dataset

erogluorhan

Thanks very much for doing this!

philipc2

Thank you once again for putting this together @rajeeja. A few more comments on casting to integers, but nothing directly related to functionality. Great work!

Fixes #142 Co-authored-by: Orhan Eroglu <erogluorhan@users.noreply.github.com>

philipc2

Changes look good! Great work

Load grids with xarray and then create uxarray grid object. Delete da…

b0fd300

…taset.py and modify all tests #151 and Discussion: #154

rajeeja requested review from dcherian and erogluorhan October 20, 2022 20:03

rajeeja added 3 commits October 20, 2022 19:00

fix merge conflicts

8b3e169

remove numpy specific dependency

a513f92

Fix return value and comments

a73f5bf

rajeeja requested review from anissa111, philipc2 and rljacob October 21, 2022 03:14

precommit

5e0c78e

philipc2 reviewed Oct 21, 2022

View reviewed changes

Comment thread uxarray/grid.py Outdated

Comment thread test/test_helpers.py Outdated

Comment thread uxarray/helpers.py Outdated

Comment thread uxarray/helpers.py Outdated

erogluorhan requested changes Oct 25, 2022

View reviewed changes

Comment thread uxarray/grid.py Outdated

Comment thread uxarray/grid.py

Comment thread uxarray/grid.py Outdated

Comment thread uxarray/helpers.py Outdated

Comment thread uxarray/grid.py Outdated

Comment thread uxarray/grid.py

Comment thread uxarray/grid.py Outdated

o Fixes as per PR comments

1490ce9

rajeeja mentioned this pull request Oct 25, 2022

Apply type hints to functions. #163

Closed

rajeeja and others added 8 commits October 25, 2022 13:59

o Changes made with Orhan, getting to approval of this PR. Remove tes…

25f9c01

…t_integrate, put those tests in test_grid - one test per .py file in uxarray folder

o Fix conversion type to np.int64

a1fc27b

Merge branch 'main' into rajeeja/remove_open_dataset

e4dae43

o Use i8, instead of i4 for int64

54eb049

Merge remote-tracking branch 'origin' into rajeeja/remove_open_dataset

07509f1

Merge branch 'rajeeja/remove_open_dataset' of github.com:UXARRAY/uxar…

2b826ac

…ray into rajeeja/remove_open_dataset

Remove traces of grid.source_datasets

a01692d

Merge branch 'main' into rajeeja/remove_open_dataset

048e4be

philipc2 reviewed Oct 25, 2022

View reviewed changes

Comment thread uxarray/_exodus.py

erogluorhan requested review from erogluorhan and philipc2 October 25, 2022 20:05

erogluorhan approved these changes Oct 25, 2022

View reviewed changes

philipc2 requested changes Oct 25, 2022

View reviewed changes

Comment thread uxarray/helpers.py Outdated

Comment thread uxarray/_scrip.py Outdated

Comment thread uxarray/grid.py Outdated

Comment thread uxarray/_exodus.py Outdated

o Use unsigned int 32 for numpy datatype

116e68f

rajeeja and others added 2 commits October 26, 2022 09:11

Usage example for calculate face areas

a31c4e7

Fixes #142 Co-authored-by: Orhan Eroglu <erogluorhan@users.noreply.github.com>

fix pre-commit

9c32341

philipc2 approved these changes Oct 26, 2022

View reviewed changes

rajeeja merged commit 5075389 into main Oct 26, 2022

erogluorhan deleted the rajeeja/remove_open_dataset branch November 2, 2022 03:01

erogluorhan linked an issue Nov 15, 2022 that may be closed by this pull request

Separate dataset and grid object #140

Closed

philipc2 mentioned this pull request Dec 22, 2022

The current data read-in will make the FillValue=nan instead of -1 #189

Closed

Uh oh!

Conversation

rajeeja commented Oct 20, 2022

Uh oh!

philipc2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

philipc2 commented Oct 24, 2022

Uh oh!

rajeeja commented Oct 24, 2022

Uh oh!

erogluorhan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erogluorhan left a comment

Choose a reason for hiding this comment

Uh oh!

philipc2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

philipc2 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants